Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Centralize injection of hosted-kubeconfig volume #311

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NO-JIRA: Centralize injection of hosted-kubeconfig volume #311

wants to merge 2 commits into from

Conversation

stephenfin
Copy link
Contributor

We have hit a critical number of users of this now that the Cinder CSI driver is adding support for Hypershift too.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2024
@openshift-ci-robot
Copy link

@stephenfin: This pull request explicitly references no jira issue.

In response to this:

We have hit a critical number of users of this now that the Cinder CSI driver is adding support for Hypershift too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and gnufied October 25, 2024 16:40
@stephenfin stephenfin force-pushed the centralise-hosted-kubeconfig branch from 700a8a6 to 616ed0c Compare January 16, 2025 12:29
jsafrane
jsafrane reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jsafrane jsafrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix issue(s) reported by verify job.
I can see it goes the right way
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@stephenfin
assets: Centralise injection of hosted-kubeconfig volume
9f368c3 
All that changes is the generated assets is the order of the volumes.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
azure-file: Remove duplicate asset patch
b69aec0 
We can use the one meant for sidecars. One less thing to keep in sync.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin stephenfin force-pushed the centralise-hosted-kubeconfig branch from 616ed0c to b69aec0 Compare January 22, 2025 12:43
@stephenfin
Copy link
Contributor Author

Please fix issue(s) reported by verify job.
I can see it goes the right way

Done

@jsafrane
Copy link
Contributor

/retest

@jsafrane
Copy link
Contributor

/lgtm
/approve
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stephenfin
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smb-operator-e2e-extended 700a8a6 link false /test smb-operator-e2e-extended
ci/prow/e2e-azurestack-csi b69aec0 link false /test e2e-azurestack-csi
ci/prow/e2e-openstack b69aec0 link false /test e2e-openstack
ci/prow/hypershift-e2e-openstack-aws-csi-manila b69aec0 link true /test hypershift-e2e-openstack-aws-csi-manila
ci/prow/e2e-azure b69aec0 link true /test e2e-azure
ci/prow/e2e-openstack-manila-csi b69aec0 link true /test e2e-openstack-manila-csi
ci/prow/e2e-openstack-cinder-csi b69aec0 link true /test e2e-openstack-cinder-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenfin @openshift-ci-robot @jsafrane