OSASINFRA-3683: openstack-manila: Remove --nodeid parameter

[stephenfin]

This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting.

Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration.

[1] kubernetes/cloud-provider-openstack#2734

Signed-off-by: Stephen Finucane [email protected]

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3683 which is a valid jira issue.

In response to this:

This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting.

Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration.

[1] kubernetes/cloud-provider-openstack#2734

Signed-off-by: Stephen Finucane [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stephenfin]

/hold

The code only just merged upstream, so this can't merge until after the next rebase of https://github.com/openshift/cloud-provider-openstack

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign dobsonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hypershift-e2e-aks	f7e7099	link	true	/test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.