Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-49737: Custom-DNS: Update master and worker user data secrets #9451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-49737: Custom-DNS: Update master and worker user data secrets #9451

wants to merge 1 commit into from

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Feb 11, 2025

When the master and worker pointer ignitions are updated, also update the user data secret for each of these roles with their respective pointer ignition contents.
Update Bootstrap ignition with updated user data secret files for master and worker.

@openshift-ci openshift-ci bot requested review from barbacbd and bfournie February 11, 2025 01:54
@sadasu sadasu changed the title Custom-DNS: Update master and worker user data secrets OCPBUGS-49737: Custom-DNS: Update master and worker user data secrets Feb 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 11, 2025
@openshift-ci-robot
Copy link
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-49737, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianli-wei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When the master and worker pointer ignitions are updated, also update the user data secret for each of these roles with their respective pointer ignition contents.
Update Bootstrap ignition with updated user data secret files for master and worker.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 11, 2025
@openshift-ci openshift-ci bot requested a review from jianli-wei February 11, 2025 01:54
@sadasu sadasu force-pushed the custom-dns-worker-ignition branch 2 times, most recently from 4ea5f77 to fb53e78 Compare February 11, 2025 03:11
@sadasu
Custom-DNS: Update master and worker user data secrets
1f96ea0 
When the master and worker pointer ignitions are updated, also
update the user data secret for each of these roles with their
respective pointer ignition contents.
Update Bootstrap ignition with updated user data secret files
for master and worker.
@sadasu sadasu force-pushed the custom-dns-worker-ignition branch from fb53e78 to 1f96ea0 Compare February 11, 2025 03:32
@sadasu
Copy link
Contributor Author

sadasu commented Feb 11, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-resourcegroup 1f96ea0 link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-vsphere-static-ovn 1f96ea0 link false /test e2e-vsphere-static-ovn
ci/prow/okd-scos-e2e-aws-ovn 1f96ea0 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

barbacbd
barbacbd reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@sadasu
Copy link
Contributor Author

sadasu commented Feb 13, 2025

/testwith openshift/installer/main/e2e-gcp-user-provisioned-dns openshift/machine-config-operator#4840, openshift/baremetal-runtimecfg#341, openshift/machine-config-operator#4830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

@bfournie bfournie Awaiting requested review from bfournie

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

Assignees
No one assigned
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadasu @openshift-ci-robot @barbacbd