OCPBUGS-53106: Create ConfigMap to reference baremetal-installer image #9563
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@zaneb: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test images |
|
/test images |
Currently the baremetal-installer container is included in the release image by virtue of being referenced by the samples operator. However, the samples operator is reportedly deprecated. Be more explicit by labeling the container image (as the regular installer container is).
zaneb
force-pushed
the
installer-imagestream
branch
from
26f8b81 to
823c249
Compare
|
/retitle: OCPBUGS-53106: Create ConfigMap to reference baremetal-installer image |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@zaneb: This pull request references Jira Issue OCPBUGS-53106, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
zaneb
changed the title
|
/jira refresh |
|
@zaneb: This pull request references Jira Issue OCPBUGS-53106, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@zaneb: This pull request references Jira Issue OCPBUGS-53106, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Have CVO maintain a ConfigMap containing the pullspec for the baremetal-installer container image in the current release image. We choose the baremetal-installer container because this is the one that can run inside the cluster - the binary always matches the cpu architecture of the container and it can run in FIPS mode. Also include the machine-os-images pullspec in the ConfigMap, for future flexibility in case it should be needed.
zaneb
force-pushed
the
installer-imagestream
branch
from
823c249 to
01dac77
Compare
|
/approve |
|
/approve PR seems to be stuck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Confirmed that this is working correctly now. |
|
@zaneb: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
|
/lgtm |
| kind: ConfigMap | ||
| metadata: | ||
| name: installer-images | ||
| namespace: openshift-config |
There was a problem hiding this comment.
@patrickdillon I chose this namespace because it doesn't depend on any capabilities and is already used by the installer to create the install ConfigMap. But you know of a more appropriate one I'd be happy to change it. (I'd prefer not to create a whole new namespace.)
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
1 similar comment
|
/retest-required |
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit 99b4874
into
openshift:main
|
@zaneb: Jira Issue OCPBUGS-53106: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-53106 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
No description provided.