OCPBUGS-48469: Fix CoreDNS static pod bring-up on cloud platforms #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
sadasu
changed the title
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
2 times, most recently
from
71cc2fd to
34e381d
Compare
sadasu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
sadasu
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@sadasu: This pull request references Jira Issue OCPBUGS-48469, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
2 times, most recently
from
513164e to
1bb98dc
Compare
sadasu
changed the title
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/retest |
yuqi-zhang
reviewed
Feb 5, 2025
| // If this is a cloud platform with DNSType set to `ClusterHosted` with | ||
| // LB IPs provided, include path for their CoreDNS files | ||
| if cloudPlatformLoadBalancerIPState(*config) == availableLBIPState { | ||
| platformBasedPaths = append(platformBasedPaths, cloudPlatformAltDNS) |
There was a problem hiding this comment.
Before this, was anything processing the templates in cloud-platform-alt-dns ? Was is being done in bootstrap only?
There was a problem hiding this comment.
It was being done on the Bootstrap node successfully and while debugging for the CoreDNS pod not starting on the master nodes, I found this issue.
|
/retest-required |
|
|
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
from
1bb98dc to
3a4599e
Compare
mkowalski
suggested changes
Feb 7, 2025
sadasu
changed the title
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
4 times, most recently
from
e8004f2 to
f8223aa
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski, sadasu, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/hold Revision 8faf96e was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required ci/prow/e2e-gcp-op-single-node has passed earlier and no code changes were made after that. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
from
8faf96e to
b44669a
Compare
|
New changes are detected. LGTM label has been removed. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
from
b44669a to
ace725e
Compare
Provide path to resolv.conf file on the master node. cluster-config.yaml file is not present on the master nodes. So, explicitly pass in platformType to baremetal-runtimecfg containers in the cloud platform CoreDNS pod.
sadasu
force-pushed
the
fix-cloud-platform-corefile
branch
from
ace725e to
0a425b0
Compare
|
/test e2e-hypershift |
|
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Results of pre-merge testing with openshift/baremetal-runtimecfg#345.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: OCPBUGS-48469
- What I did
- How to verify it
Set
UserProvisionedDNStoEnabledfor GCP via install-config and start installation- Description for the changelog
Fixed issues with CoreDNS Corefile and template path for cloud platforms when UserProvisionedDNS is enabled.
Added test_data for GCP with all the UserProvisionedDNS configuration to better test this path.