-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRACING-4875 | RHOSDT 3.5: OTEL add AWS exporters #88167
Conversation
Signed-off-by: Pavol Loffay <[email protected]>
Skipping CI for Draft Pull Request. |
@pavolloffay, you can close this PR because I've added it to my corresponding Jiras. Thank you, just in time. |
@pavolloffay, thank you for this draft. You can close it now because I opened #88479. |
The AWS CloudWatch exporter sends logs data to link:https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html[AWS CloudWatch Logs]. | ||
AWS credentials are retrieved from the link:https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html#specifying-credentials[default credential chain]. | ||
|
||
:FeatureName: The AWS CloudWatch exporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavolloffay, is this https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/awscloudwatchlogsexporter? If so, should I rename it to AWS CloudWatch Logs Exporter
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
== AWS CloudWatch Exporter | ||
|
||
The AWS CloudWatch exporter sends logs data to link:https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html[AWS CloudWatch Logs]. | ||
AWS credentials are retrieved from the link:https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html#specifying-credentials[default credential chain]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavolloffay, question, there are docs for v1
and v2
. They recommend v2
. Do you still prefer to document v1
? (I don't care, just want to clarify this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep the v2 link but just comment it out until further notice.
config: | ||
exporters: | ||
awsxray: | ||
region: eu-west-1 # <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavolloffay, no double quotes for eu-west-1
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add them for consistency, but it should not matter
Version(s):
OCP 4.12-4.19
RHOSDT 3.5
Issue:
All components are added as tech-preview
Link to docs preview:
QE review:
Additional information:
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/awscloudwatchlogsexporter
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/awsemfexporter
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/awsxrayexporter