Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACING-4875 | RHOSDT 3.5: OTEL add AWS exporters #88167

Closed
wants to merge 1 commit into from

Conversation

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2025
Copy link

openshift-ci bot commented Feb 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2025
@pavolloffay pavolloffay changed the title TRACING-4875 | RHOSDT: OTEL add AWS exporters TRACING-4875 | RHOSDT 3.5: OTEL add AWS exporters Feb 7, 2025
@max-cx
Copy link
Contributor

max-cx commented Feb 7, 2025

@pavolloffay, you can close this PR because I've added it to my corresponding Jiras. Thank you, just in time.

@max-cx
Copy link
Contributor

max-cx commented Feb 12, 2025

@pavolloffay, thank you for this draft. You can close it now because I opened #88479.

The AWS CloudWatch exporter sends logs data to link:https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html[AWS CloudWatch Logs].
AWS credentials are retrieved from the link:https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html#specifying-credentials[default credential chain].

:FeatureName: The AWS CloudWatch exporter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

== AWS CloudWatch Exporter

The AWS CloudWatch exporter sends logs data to link:https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html[AWS CloudWatch Logs].
AWS credentials are retrieved from the link:https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html#specifying-credentials[default credential chain].
Copy link
Contributor

@max-cx max-cx Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay, question, there are docs for v1 and v2. They recommend v2. Do you still prefer to document v1? (I don't care, just want to clarify this).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep the v2 link but just comment it out until further notice.

config:
exporters:
awsxray:
region: eu-west-1 # <1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay, no double quotes for eu-west-1 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add them for consistency, but it should not matter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants