Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-13070-415: backport adding EUS repos MicroShift 4.15 #88192

Merged
merged 1 commit into from
Feb 11, 2025
Merged

OSDOCS-13070-415: backport adding EUS repos MicroShift 4.15 #88192

merged 1 commit into from
Feb 11, 2025

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Feb 6, 2025 •
edited
Loading

@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Feb 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-13070 which is a valid jira issue.

In response to this:

Version(s):
4.15

Issue:
OSDOCS-13070

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Backports #87660

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-13070 which is a valid jira issue.

In response to this:

Version(s):
4.15

Issue:
OSDOCS-13070

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Backports #87660

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-13070-415 branch 2 times, most recently from 59499f4 to 0b884bf Compare February 6, 2025 19:05
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 6, 2025 •
edited
Loading

🤖 Mon Feb 10 19:15:55 - Prow CI generated the docs preview:

https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_install/microshift-embed-in-rpm-ostree.html
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-options.html
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-rpms-manually.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-13070 which is a valid jira issue.

In response to this:

Version(s):
4.15

Issue:
OSDOCS-13070

Link to docs preview:
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_install/microshift-embed-in-rpm-ostree.html
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-options.html
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-rpms-manually.html

QE review:

  • QE has approved this change.

Additional information:
Backports #87660

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jogeo
jogeo reviewed Feb 6, 2025
View reviewed changes
Copy link

@jogeo jogeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion, otherwise LGTM.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-13070 which is a valid jira issue.

In response to this:

Version(s):
4.15

Issue:
OSDOCS-13070

Link to docs preview:
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_install/microshift-embed-in-rpm-ostree.html
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-options.html
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-rpms-manually.html

QE review:

  • QE has approved this change.

Additional information:
Backports #87660, incorporates #88190

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-13070 which is a valid jira issue.

In response to this:

Version(s):
4.15

Issue:
OSDOCS-13070

Link to docs preview:
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_install/microshift-embed-in-rpm-ostree.html
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-options.html
https://88192--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-rpms-manually.html

QE review:

  • QE has approved this change.

Additional information:
Backports #87660, incorporates #88190

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 10, 2025
@ShaunaDiaz ShaunaDiaz changed the title OSDOCS-13070-415: manual CP back of OSDOCS-13070 OSDOCS-13070-415: backport adding EUS repos MicroShift Feb 10, 2025
@ShaunaDiaz ShaunaDiaz changed the title OSDOCS-13070-415: backport adding EUS repos MicroShift OSDOCS-13070-415: backport adding EUS repos MicroShift 4.15 Feb 10, 2025
@lahinson lahinson added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 10, 2025
lahinson
lahinson reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple nits and one question about callout text.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.15 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 10, 2025
@lahinson lahinson mentioned this pull request Feb 10, 2025
Merged
1 task
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 10, 2025

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit a40b9c4 into openshift:enterprise-4.15 Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo jogeo left review comments

@lahinson lahinson lahinson left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
5 participants
@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @jogeo @lahinson