-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-8759 Pre-migration checklist for product docs #88198
OSSM-8759 Pre-migration checklist for product docs #88198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Just a few comments.
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
6c93f06
to
2cfdbda
Compare
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
@gwynnemonahan should we wait for missing links before approval or there will be another PR for adding links so it will be reviewed again there? |
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
Hey @FilipB , Thanks for asking! At the moment, I'm OK with waiting on this PR. It is looking like this will be the last, or one of the last PRs for Migration content to be merged so that the links can be added and checked that they work. There's also a change I need to make regarding the checker script. |
d0b4772
to
c347da4
Compare
c347da4
to
9cd687d
Compare
9cd687d
to
d9cb366
Compare
8ef4ce3
to
bfc2ce7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions. Also we are still waiting for the links to be working before final approval.
modules/ossm-migrating-premigration-checklists-network-policies.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-resource-files.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-resource-files.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-network-policies.adoc
Outdated
Show resolved
Hide resolved
3096231
to
0ee4fc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple formatting nits but otherwise LGTM
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-resource-files.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this content is in between content types. As a result, it has an unfinished feeling to it.
I think that as a rule of thumb, a checklist should be part of an assembly and link/xref out to the relevant procedures. And if links are not necessary and the content is intended for reuse, the checklist should be a reference module.
For most of my comments, a slight refactoring of content to align that suggestion will solve the issues. But a few of these modules are procedure or reference modules (and not checklists), and should be used in that way.
That said, I don't it will take too much to get this into shape. Please reach out if you have questions. I am happy to hop on a call to discuss.
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-using-cert-manager.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-using-cert-manager.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-using-cert-manager.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-using-cert-manager.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-migrating-premigration-checklists-using-cert-manager.adoc
Outdated
Show resolved
Hide resolved
7a5218d
to
2037fb1
Compare
Rebased night 03/03/2025. |
83d9131
to
f20ecd6
Compare
Rebased morning 03/04/2025 |
/label merge-review-needed |
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Show resolved
Hide resolved
migrating/checklists/ossm-migrating-premigration-checklists-assembly.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments about minimalism here before merging.
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I won't hold merge on this, but after some discussion with the reviewers of this PR and @kalexand-rh, we've decided that the best course of action is a re-evaluation of some of the minimalism and modularization comments in the review that weren't addressed, or were ACK'd pending user feedback. A Jira task has been created to ensure that this content is re-evaluated for consistency with these standards because, as is, this checklist does not align: https://issues.redhat.com/browse/OSSM-9002 |
/cherrypick service-mesh-docs-3.0 |
@skrthomas: new pull request created: #89563 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OSSM 3.0 GA
Per Kathryn, used this as an example: https://docs.openshift.com/container-platform/4.17/migrating_from_ocp_3_to_4/premigration-checklists-3-4.html
Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0
This PR is part of the standalone doc set for the OpenShift Service Mesh project.
Version(s):
OSSM 3.0 GA
OSSM 3.0 is moving to stand alone format so it will not be cherry-picked back to OCP core branches.
Issue:
https://issues.redhat.com/browse/OSSM-8759
Link to docs preview:
https://88198--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/checklists/ossm-migrating-network-policies-assembly.html
https://88198--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/checklists/ossm-migrating-premigration-checklists-assembly.html
https://88198--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/ossm-migrating-from-service-mesh-2-to-3-assembly.html
QE review:
Additional information:
IA PR for reference: #86912