Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS#13072:Adds Content Security Policy for web console #88593

Merged
merged 1 commit into from
Feb 18, 2025
Merged

OSDOCS#13072:Adds Content Security Policy for web console #88593

merged 1 commit into from
Feb 18, 2025

Conversation

opayne1
Copy link
Contributor

@opayne1 opayne1 commented Feb 13, 2025 •
edited
Loading

OSDOCS#13072:Adds Content Security Policy for web console

Version(s):
4.18

Issue:
https://issues.redhat.com/browse/OSDOCS-13072

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2025
@opayne1
Copy link
Contributor Author

opayne1 commented Feb 13, 2025

@jhadvig PTAL. Thanks! 😄

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 13, 2025 •
edited
Loading

🤖 Tue Feb 18 15:48:27 - Prow CI generated the docs preview:

https://88593--ocpdocs-pr.netlify.app/openshift-dedicated/latest/web_console/dynamic-plugin/dynamic-plugin-example.html
https://88593--ocpdocs-pr.netlify.app/openshift-enterprise/latest/web_console/dynamic-plugin/content-security-policy.html
https://88593--ocpdocs-pr.netlify.app/openshift-enterprise/latest/web_console/dynamic-plugin/dynamic-plugin-example.html
https://88593--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/web_console/dynamic-plugin/dynamic-plugin-example.html
https://88593--ocpdocs-pr.netlify.app/openshift-rosa/latest/web_console/dynamic-plugin/dynamic-plugin-example.html

jhadvig
jhadvig reviewed Feb 14, 2025
View reviewed changes
@opayne1 opayne1 force-pushed the OSDOCS-13072 branch 2 times, most recently from 577aa13 to 96131c8 Compare February 14, 2025 16:53
@opayne1
Copy link
Contributor Author

opayne1 commented Feb 14, 2025

@yapei Could I also get a QE review of this PR for CSP? Thank you! 😄

yapei
yapei reviewed Feb 17, 2025
View reviewed changes
yapei
yapei reviewed Feb 17, 2025
View reviewed changes
@opayne1 opayne1 force-pushed the OSDOCS-13072 branch 2 times, most recently from e9f6746 to 98265aa Compare February 17, 2025 16:25
@opayne1 opayne1 added this to the Planned for 4.18 GA milestone Feb 17, 2025
@opayne1 opayne1 added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 17, 2025
@jldohmann jldohmann added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 17, 2025
jldohmann
jldohmann reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work Olivia! just a couple minor comments

@jldohmann jldohmann added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 17, 2025
yapei
yapei reviewed Feb 18, 2025
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 18, 2025

@opayne1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@opayne1 opayne1 merged commit 0393a52 into openshift:main Feb 18, 2025
2 checks passed
@opayne1
Copy link
Contributor Author

opayne1 commented Feb 18, 2025

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #88802

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig left review comments

@yapei yapei yapei left review comments

@jldohmann jldohmann jldohmann left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.18 GA
Development

Successfully merging this pull request may close these issues.
6 participants
@opayne1 @ocpdocs-previewbot @openshift-cherrypick-robot @jhadvig @yapei @jldohmann