Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSDOCS#13402] Restore RHOSO monitoring topic to nav #88850

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Feb 18, 2025

Version(s): 4.18+

Issue: OSDOCS-13402

Link to docs preview: https://88850--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/shiftstack-prometheus-configuration.html

QE review:
- [ ] QE has approved this change.

Additional information: This PR just re-adds documentation introduced in #86741 to the nav, as well as fixes some links. It was wiped by a re-org force push (or something) after its publication. All content was already peer reviewed.

@maxwelldb maxwelldb added this to the Planned for 4.18 GA milestone Feb 18, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 18, 2025

@maxwelldb maxwelldb changed the title [NOJIRA] Restore RHOSO monitoring topic to nav [OSDOCS#13402] Restore RHOSO monitoring topic to nav Feb 19, 2025
@maxwelldb maxwelldb force-pushed the restore-rhoso-monitoring branch from 7938b7b to 1e33cdc Compare February 19, 2025 02:17
@maxwelldb maxwelldb added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.18 labels Feb 19, 2025
Copy link

openshift-ci bot commented Feb 19, 2025

@maxwelldb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 19, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 19, 2025
@maxwelldb
Copy link
Contributor Author

/cherry-pick enterprise-4.18

@openshift-cherrypick-robot

@maxwelldb: once the present PR merges, I will cherry-pick it on top of enterprise-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maxwelldb maxwelldb merged commit f90e33c into openshift:main Feb 19, 2025
2 checks passed
@maxwelldb maxwelldb deleted the restore-rhoso-monitoring branch February 19, 2025 12:50
@openshift-cherrypick-robot

@maxwelldb: new pull request created: #88873

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants