Ensure OS environment variables are wired into list command as well
#29582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
When getting the list of tests, we need to have origin's environment variables. Some users are setting TEST_PROVIDER when invoking openshift-tests, which for `run` this gets overwritten with the correct ones from the cluster environment[1], but this doesn't happen with `list`. An upcoming change is going to require initializing the test framework even to list tests, which means we'll need to have the TEST_PROVIDER correctly set. [1] https://github.com/openshift/origin/blob/main/pkg/test/ginkgo/test_runner.go#L380-L403
stbenjam
force-pushed
the
update-env-vars-list-test
branch
from
c1ddb97 to
0055a0b
Compare
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 0055a0b
Showing 20 of 43 jobs analysis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the list of tests, we need to have origin's environment variables.
Some users are setting TEST_PROVIDER when invoking openshift-tests, which for
runthis gets overwritten with the correct ones from the cluster environment[1], but this doesn't happen withlist.An upcoming change is going to require initializing the test framework even to list tests, which means we'll need to have the TEST_PROVIDER correctly set.
[1] https://github.com/openshift/origin/blob/main/pkg/test/ginkgo/test_runner.go#L380-L403