Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO-1594: updates for ManagedBootImageStatus #29598

Merged
merged 2 commits into from
Mar 14, 2025
Merged

MCO-1594: updates for ManagedBootImageStatus #29598

merged 2 commits into from
Mar 14, 2025

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented Mar 13, 2025 •
edited
Loading

This PR modifies boot image update tests:

  • Use the explicit opt-out knob when opting out
  • Skip the degrade test temporarily
  • ensure cleanups are done in success or fail

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2025 •
edited by openshift-ci bot
Loading

@djoshy: This pull request references MCO-1594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This PR modifies boot image update tests:

  • Use the explicit opt-out knob when opting out
  • Skip the degrade test temporarily

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cheesesashimi and deads2k March 13, 2025 20:59
yuqi-zhang
yuqi-zhang approved these changes Mar 14, 2025
View reviewed changes
Copy link

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
@sosiouxme
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 59d86be and 2 for PR HEAD c8d5d3b in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2025 •
edited by openshift-ci bot
Loading

@djoshy: This pull request references MCO-1594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This PR modifies boot image update tests:

  • Use the explicit opt-out knob when opting out
  • Skip the degrade test temporarily
  • ensure cleanups are done in success or fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-etcd-scaling c8d5d3b link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive c8d5d3b link false /test e2e-gcp-disruptive
ci/prow/e2e-vsphere-ovn-etcd-scaling c8d5d3b link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive c8d5d3b link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-etcd-scaling c8d5d3b link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-upgrade c8d5d3b link false /test e2e-azure-ovn-upgrade
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback c8d5d3b link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-aws-ovn-kube-apiserver-rollout c8d5d3b link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-upgrade c8d5d3b link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/okd-e2e-gcp c8d5d3b link false /test okd-e2e-gcp
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 c8d5d3b link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-fips-serial c8d5d3b link false /test e2e-gcp-fips-serial
ci/prow/e2e-azure-ovn-etcd-scaling c8d5d3b link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-openstack-serial c8d5d3b link false /test e2e-openstack-serial
ci/prow/e2e-gcp-ovn-rt-upgrade c8d5d3b link false /test e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@djoshy
Copy link
Contributor Author

djoshy commented Mar 14, 2025

/periodic-job periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-ovn-serial-aws-multi-a-a

yuqi-zhang
yuqi-zhang reviewed Mar 14, 2025
View reviewed changes
Copy link

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new cleanups looks good!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, sosiouxme, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor

/payload-job periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-ovn-serial-aws-multi-a-a

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-ovn-serial-aws-multi-a-a

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a7de4c40-00f0-11f0-8b89-1c6b8de2ea60-0

@openshift-merge-bot openshift-merge-bot bot merged commit adfcb39 into openshift:main Mar 14, 2025
34 of 54 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202503142240.p0.gadfcb39.assembly.stream.el9.
All builds following this will include this PR.

@djoshy djoshy deleted the add-opt-out branch March 27, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@djoshy @openshift-ci-robot @sosiouxme @JoelSpeed @openshift-bot @yuqi-zhang