add: new project The-book-of-optimism-fault-proof #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joohhnnn
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
ccerv1
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Hi there, we have a separate project already for you here:
https://github.com/opensource-observer/oss-directory/blob/main/data/projects/u/understanding-optimism-codebase-joohhnnn.yaml
This gives you two options:
- Merge: Add the Github urls to that projects and update the name
- Separate: Keep a separate file for each project, but remove the address from the new one -- we can't have two projects "own" the same address
Both are totally fine... up to you!
ccerv1
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
joohhnnn
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
Thanks for the advice. I use a new address for the Separate case. PLZ check again. |
…f-optimism-fault-proof-joohhnnn.yaml * updated `filename` and `name` field to include repo owner * address `tag` is an EOA, not a smart contract * moved the address `name` to its own field
ccerv1
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
|
/validate d78dbda |
ccerv1
approved these changes
Sep 5, 2024
Validation Results✅ Good to go as long as status checks pass commit Overview0xe654866d4ee84dacf6e67f4bd561cd7f5c714006
|
Aghostraa
pushed a commit
to Aghostraa/oss-directory
that referenced
this pull request
Oct 26, 2024
…r#479) * Create The-book-of-optimism-fault-proof.yaml * update the address * Update and rename The-book-of-optimism-fault-proof.yaml to the-book-of-optimism-fault-proof-joohhnnn.yaml * updated `filename` and `name` field to include repo owner * address `tag` is an EOA, not a smart contract * moved the address `name` to its own field --------- Co-authored-by: Carl Cervone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there Im not sure if there is a tag named fault proof. If not, PLZ delete it.