-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated preview instances of iD for tagging PRs #800
Conversation
a34c638
to
7e0308b
Compare
4ca2c5a
to
7774e92
Compare
d834346
to
22ebd15
Compare
Could you change the preview URL that the bot comments to include |
Also, I assume that openstreetmap/openstreetmap-website#3955 (comment) is a big |
This looks great and the PR you linked works as I would expect. The article I linked at https://github.com/openstreetmap/id-tagging-schema/pull/800/files#r1124938112 had some hints at how to maybe speed up the npm install further with some caching stuff, but I don't know if that would be relevant (enough) for this use case. This will be a great improvement. One thing that should likely be part of the PR is an update to the Readme on how to contribute and use this new feature. |
What exactly did you have in mind which should be mentioned in the Readme? As the bot automatically posts a comment directly on each PR, the contributors don't have to do anything manually and the message in the posted comment should be sufficiently "documenting" what it is about?! So, basically I don't know what exactly to put into the readme. |
Closes #289.
Example of how it will look like: tyrasd#3.
Currently, this has some small limitations:
To do:
NETLIFY_AUTH_TOKEN
,NETLIFY_SITE_ID
)PS: This is very much "inspired" by the implementation made in the openlayers.