chore: add missing InlineEdit export #4393

erha19 · 2025-02-20T15:16:29Z

Types

🐛 Bug Fixes

Background or solution

Changelog

add missing InlineEdit export

Summary by CodeRabbit

新功能
- 引入了内联编辑功能，支持对指定文本区域进行直接编辑。
- 新增触发选项，包括手动和自动模式，进一步提升文本修改的灵活性。
- 扩展了API接口，使得扩展程序能够更好地集成和利用这一编辑特性。

erha19 · 2025-02-20T15:16:48Z

/next

coderabbitai · 2025-02-20T15:19:38Z

Walkthrough

此次改动新增了 VSCode 扩展包内的两个公共实体：一个是实现行内编辑操作的 InlineEdit 类，另一个是定义触发类型的 InlineEditTriggerKind 枚举。同时，在 API 实现文件中，createApiFactory 方法被扩展，新增了对这两个实体的导出，保持了现有功能的完整性。

Changes

文件	更改摘要
packages/extension/src/common/vscode/ext-types.ts	新增 `InlineEdit` 类和 `InlineEditTriggerKind` 枚举，实现行内编辑功能
packages/extension/src/hosted/api/vscode/ext.host.api.impl.ts	在 `createApiFactory` 中新增对 `InlineEdit` 和 `InlineEditTriggerKind` 的导出
packages/extension/src/hosted/api/worker/worker.host.api.impl.ts	在 `createAPIFactory` 的返回对象中新增 `InlineEdit` 和 `InlineEditTriggerKind` 属性

Sequence Diagram(s)

sequenceDiagram
    participant Ext as 扩展程序
    participant Api as API 工厂
    participant Types as 类型定义模块
    Ext->>Api: 请求执行行内编辑操作
    Api->>Types: 调用并实例化 InlineEdit(text, range)
    Types-->>Api: 返回 InlineEdit 实例
    Api-->>Ext: 传递行内编辑数据

Possibly related PRs

feat: support VSCode API: SnippetTextEdit #4154: 此 PR 与当前改动存在代码级关联，共同改善了内联编辑相关的功能。
fix: inline input edit operations #3876: 此 PR 与当前改动存在代码级关联，共同改善了内联编辑相关的功能。

Suggested labels

🐞 bug, 🎨 feature

Suggested reviewers

bytemain
Ricbet

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b632b9 and b3ff34e.

📒 Files selected for processing (1)

packages/extension/src/hosted/api/worker/worker.host.api.impl.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
GitHub Check: unittest (ubuntu-latest, 18.x, node)
GitHub Check: unittest (macos-latest, 18.x, jsdom)
GitHub Check: unittest (macos-latest, 18.x, node)
GitHub Check: build (ubuntu-latest, 20.x)
GitHub Check: build (macos-latest, 20.x)
GitHub Check: ubuntu-latest, Node.js 20.x
GitHub Check: build-windows

🔇 Additional comments (1)

packages/extension/src/hosted/api/worker/worker.host.api.impl.ts (1)

241-242:
❓ Verification inconclusive

新增的导出项符合预期！

新增的 InlineEdit 和 InlineEditTriggerKind 导出项的位置合理，与其他内联相关的类型（如 InlineCompletionItem）放在一起，保持了代码的一致性。

建议验证导出项的完整性。

请确认 worker.ext-types.ts 文件中已正确定义了这两个导出项。

🏁 Script executed:
#!/bin/bash
# 描述：验证 worker.ext-types.ts 中是否包含 InlineEdit 和 InlineEditTriggerKind 的定义

# 测试：搜索这两个类型的定义
rg -A 5 'InlineEdit|InlineEditTriggerKind' './packages/extension/src/hosted/api/worker/worker.ext-types.ts'
Length of output: 107
确认新增导出项的位置和意图正确，但未在 worker.ext-types.ts 中检索到 InlineEdit 与 InlineEditTriggerKind 的定义。

请开发者手动检查或进一步验证 worker.ext-types.ts 文件，确认这两个导出项是否已正确定义。如果尚未定义，请补充相应的实现。

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

opensumi · 2025-02-20T15:21:36Z

🎉 PR Next publish successful!

3.7.2-next-1740064823.0

codecov · 2025-02-20T15:31:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.73%. Comparing base (29f48cd) to head (b3ff34e).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4393      +/-   ##
==========================================
- Coverage   53.85%   53.73%   -0.12%     
==========================================
  Files        1651     1655       +4     
  Lines      101670   101889     +219     
  Branches    21984    22036      +52     
==========================================
- Hits        54754    54751       -3     
- Misses      39015    39203     +188     
- Partials     7901     7935      +34

Flag	Coverage Δ
jsdom	`49.24% <ø> (-0.11%)`	⬇️
node	`12.22% <ø> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

erha19 · 2025-02-20T15:46:36Z

/next

opensumi · 2025-02-20T15:51:30Z

🎉 PR Next publish successful!

3.7.2-next-1740066619.0

Aaaaash

LGTM

chore: add missing class export

7b632b9

erha19 requested review from hacke2, ensorrow, Aaaaash and Ricbet February 20, 2025 15:16

chore: add inline edit api to worker host api

b3ff34e

Aaaaash approved these changes Feb 21, 2025

View reviewed changes

Ricbet approved these changes Feb 21, 2025

View reviewed changes

erha19 merged commit 21867c6 into main Feb 21, 2025
13 checks passed

erha19 deleted the feat/support-worker-host-inlineEdit-api branch February 21, 2025 01:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add missing InlineEdit export #4393

chore: add missing InlineEdit export #4393

erha19 commented Feb 20, 2025 •

edited by coderabbitai bot

Loading

erha19 commented Feb 20, 2025

coderabbitai bot commented Feb 20, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

opensumi bot commented Feb 20, 2025

codecov bot commented Feb 20, 2025 •

edited

Loading

erha19 commented Feb 20, 2025

opensumi bot commented Feb 20, 2025

Aaaaash left a comment

chore: add missing InlineEdit export #4393

chore: add missing InlineEdit export #4393

Conversation

erha19 commented Feb 20, 2025 • edited by coderabbitai bot Loading

Types

Background or solution

Changelog

Summary by CodeRabbit

erha19 commented Feb 20, 2025

coderabbitai bot commented Feb 20, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

opensumi bot commented Feb 20, 2025

codecov bot commented Feb 20, 2025 • edited Loading

Codecov Report

erha19 commented Feb 20, 2025

opensumi bot commented Feb 20, 2025

Aaaaash left a comment

Choose a reason for hiding this comment

erha19 commented Feb 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Feb 20, 2025 •

edited

Loading