fix(fluent-editor): fix link and img render error

[kagol]

PR

tiny-vue/packages/renderless/src/fluent-editor/index.ts

Line 68 in 3e24748

let temp = xss.filterHtml(state.content)

原因是白名单里遗漏了 <a href> / <img src>

tiny-vue/packages/renderless/src/common/xss.ts

Line 25 in 3e24748

a: ['class', 'style', 'contenteditable', 'data-id', 'data-title', 'data-size', 'data-last-modified'],

tiny-vue/packages/renderless/src/common/xss.ts

Line 77 in 3e24748

img: ['class', 'style', 'devui-editorx-image', 'style', 'data-image-id'],

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: #2141

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • Enhanced security configuration to allow href attributes for links and src attributes for images, improving flexibility in content handling while maintaining XSS protection.

[coderabbitai]

Walkthrough

The changes in this pull request enhance the xssOptions configuration in the xss.ts file by adding the href attribute to the <a> tag and the src attribute to the <img> tag within the whiteList object. This modification allows these elements to support additional attributes while maintaining security against XSS vulnerabilities.

Changes

Files	Change Summary
packages/renderless/src/common/xss.ts	Modified xssOptions to include href for <a> tags and src for <img> tags in whiteList.

Suggested labels

bug

Suggested reviewers

• zzcr

Poem

In the garden where links can twine,
With images bright, oh how they shine!
A hop and a skip, the code is now free,
To dance with new attributes, joyfully!
XSS, beware, for we’ve fortified,
Our HTML blooms, with safety applied! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3e24748 and 83e2362.

Files selected for processing (1)

• packages/renderless/src/common/xss.ts (2 hunks)

Additional comments not posted (2)

packages/renderless/src/common/xss.ts (2)

25-25: LGTM!

Adding the href attribute to the allowed attributes for the <a> tag is necessary for rendering functional links. This change maintains the balance between enabling essential functionality and providing XSS protection.

---

77-77: LGTM!

Adding the src attribute to the allowed attributes for the <img> tag is necessary for rendering images. This change maintains the balance between enabling essential functionality and providing XSS protection.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide