-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(date-picker): [date-picker] modify variable names and styles for date-picker #2340
refactor(date-picker): [date-picker] modify variable names and styles for date-picker #2340
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces significant enhancements to various components within the UI library, particularly focusing on the picker, date, time, and range components. Key changes include the addition of new functions for managing state and formatting, updates to CSS variable naming conventions, and structural modifications to Vue component templates for improved layout. The changes aim to streamline styling and enhance functionality, including better handling of time ranges, improved state management, and a more organized approach to CSS variables across components. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PickerComponent
participant DatePanel
participant TimePanel
User->>PickerComponent: Select date or time
PickerComponent->>DatePanel: Update state and display date
PickerComponent->>TimePanel: Update state and display time
DatePanel->>User: Show selected date
TimePanel->>User: Show selected time
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@pick="handleRangePick" | ||
> | ||
</month-table> | ||
<div class="tiny-date-range-picker__table"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改变了模板,需要评估下是否对saas主题造成影响?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已贴图,没有,就是在表格的外层加个div
…es for date-picker
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit