Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag): update tag's size when only icon, update one place of button's size #2438

Closed

Conversation

shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented Oct 28, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

增加tag的only icon时, 不同尺寸时的大小

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced new <tiny-tag> components with icon-only variations for different sizes, enhancing visual representation.
    • Added new icons to the application, expanding the available icon set.
  • Bug Fixes

    • Improved clarity in documentation regarding the only-icon property for tags.
  • Style

    • Updated styles for tags containing only icons to enhance their appearance.
    • Adjusted icon size for small buttons to improve visual consistency.
  • Chores

    • Reformatted JSON files for better readability and organization.

@github-actions github-actions bot added the bug Something isn't working label Oct 28, 2024
Copy link

coderabbitai bot commented Oct 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces enhancements to the <tiny-tag> component across several files, adding new instances configured with the only-icon attribute to demonstrate icon-only variations. The IconHeartempty component is imported and utilized for these tags. Documentation updates clarify the use of the only-icon property. Additionally, modifications are made to the export structure in various files, including the removal of the DialogSelect component and updates to CSS variables related to icon size and tag styling.

Changes

File Path Change Summary
examples/sites/demos/pc/app/tag/size-composition-api.vue Added four <tiny-tag> components with only-icon attribute using TinyIconHeartempty.
examples/sites/demos/pc/app/tag/size.vue Introduced four new tiny-tag components utilizing only-icon property with TinyIconHeartempty.
examples/sites/demos/pc/app/tag/webdoc/tag.js Updated documentation for only-icon property in basic-usage demo for clarity and readability.
packages/design/aurora/index.ts Removed DialogSelect from exports; retained Popeditor.
packages/modules.json Reformatted "mode" property to multi-line; renamed IconSaas to IconMulticolor and vice versa.
packages/theme/src/button/vars.less Updated icon size variable for small buttons from 14px to 16px.
packages/theme/src/index.less Added import for base-select component.
packages/theme/src/tag/index.less Enhanced styling for tags with only icons; added new rules for padding and font size.
packages/theme/src/tag/vars.less Added new CSS properties for icon-only tags; removed two existing properties related to small size.
packages/vue-icon-saas/index.ts Added new icons: IconFeedback, IconFullscreenRight, IconLocalePanel, IconShutdown, IconUpdate, IconAgency.

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • zzcr

Poem

In the garden of tags, new icons bloom,
Tiny hearts flutter, dispelling the gloom.
With colors so bright, and sizes so small,
Our tags now dance, enchanting us all!
A hop and a skip, let the icons play,
In this joyful update, hip-hip-hooray! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@shenjunjian shenjunjian deleted the relase319-tag-size-icon-only branch November 7, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants