-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form): [form] Fix the popper-options page demo style issue #3114
Conversation
WalkthroughThis pull request updates the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS Optional dependencies cannot be installed without production dependencies 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses a style issue in the popper-options page demo by adjusting the Changes
|
@@ -1,7 +1,7 @@ | |||
<template> | |||
<div class="demo-form"> | |||
<div class="scroll-parent"> | |||
<tiny-form ref="formRef" :model="createData" label-width="60px" :popper-options="{ bubbling: true }"> | |||
<tiny-form ref="formRef" :model="createData" label-width="70px" :popper-options="{ bubbling: true }"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the change in label-width
from 60px
to 70px
does not affect the layout or functionality of other components within the demo. Verify that this change resolves the style issue without introducing new problems.
@@ -1,7 +1,7 @@ | |||
<template> | |||
<div class="demo-form"> | |||
<div class="scroll-parent"> | |||
<tiny-form ref="form" :model="createData" label-width="60px" :popper-options="{ bubbling: true }"> | |||
<tiny-form ref="form" :model="createData" label-width="70px" :popper-options="{ bubbling: true }"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the change in label-width
from 60px
to 70px
does not affect the layout or functionality of other components within the demo. Verify that this change resolves the style issue without introducing new problems.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit