Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Switched to prettier for CSS/JS formatting #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

youhaveme9
Copy link

No description provided.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is still using openwisp-utils[qa]~=1.1.0, so probably that's why the QA checks are failing. I am not 100% sure the warning is the culprit of the QA checks failure.

@youhaveme9
Copy link
Author

@nemesifier
This should fix ig

@youhaveme9
Copy link
Author

youhaveme9 commented Jan 30, 2025

Hey @nemesifier
I think we should use openwsip-utils[qa] @ https://github.com/openwisp/openwisp-utils/tarball/1.2 for correct openwsip-utils version
But this line exceeds the character limit check of flake8

./setup.py:24:89: E501 line too long (90 > 88 characters)
ERROR: Flake8 check failed!

I have used multiline string to fix this
Would it work?

setup.py Outdated
Comment on lines 24 to 25
'''openwisp-utils[qa]
@ https://github.com/openwisp/openwisp-utils/tarball/1.2''',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'''openwisp-utils[qa]
@ https://github.com/openwisp/openwisp-utils/tarball/1.2''',
(
'openwisp-utils[qa]'
' @ https://github.com/openwisp/openwisp-utils/tarball/1.2'
),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants