-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
softethervpn: fix build on macos #17611
softethervpn: fix build on macos #17611
Conversation
knxd failure. Weird. |
@neheb do you think this issue is somehow related to my commit? |
no. I would try rebasing against master anyway. |
yeah there's a version update with master. |
@neheb I didn't get your 2 last comments. softerthervpn master (5.x) is: https://github.com/SoftEtherVPN/SoftEtherVPN (for developers) softerthervpn master doesn't have the files I patched. As I understand, there is no reason to use softerthervpn master due to it is a version for developers. |
i mean packages.git master.
|
I'm sorry but I still don't undestand. This PR has no conflicts with packages repo. Last update for softethervpn was in October 2021, but my tree is January 2022 |
right. my point is ARC is failing because of knxd. knxd is fixed in current master. rebasing will make it succeed. |
host-compile fails on macos due to several reasons: 1. host-compile Makefile always selected for linux 2. macos host cc (clang) fails due to implicit-function-declaration 3. ar and ranlib tools are hardcoded in softethervpn Makefiles All three issues are fixed by this patch Signed-off-by: Sergey V. Lobanov <[email protected]>
bc8e3e3
to
d648a06
Compare
@neheb thanks, rebase helped |
host-compile fails on macos due to several reasons:
All three issues are fixed by this patch
Signed-off-by: Sergey V. Lobanov [email protected]
Maintainer: @fededim
Compile tested: (armvirt/64, OpenWrt trunk)
PR to upstream: SoftEtherVPN/SoftEtherVPN_Stable#20
Description: see above