Adds a provisioning api #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: add rationale section for ignoring redundant. Based on a conversation earlier, this allows consitent processing without having implementations need to deal with merge rules for a non-use case |
| @@ -42,23 +45,35 @@ | |||
| String maybeValue = getter.get(request, samplingKey); | |||
| if (maybeValue == null) return result; | |||
|
|
|||
| SecondarySampling.Extra extra = EXTRA_FACTORY.create(); | |||
| boolean sampledLocal = false; | |||
| SampledLocalMap initial = new SampledLocalMap(); | |||
There was a problem hiding this comment.
Nicely abstracted! So same api is used for both provisioning and participation.
There was a problem hiding this comment.
yep in order to save bytecode and thinking. thx!
|
ok picking this up again |
brave/src/test/java/brave/secondary_sampling/integration/SecondarySamplingIntegratedTest.java
Outdated
Show resolved
Hide resolved
This is a work in progress until unit and integration tests exist. Fixes #10
codefromthecrypt
force-pushed
the
provisioner
branch
from
09f7490 to
dd3699a
Compare
| @@ -65,12 +65,14 @@ public String samplingKey() { | |||
|
|
|||
| /** Retrieves the current TTL of this {@link #samplingKey()} or zero if there is none. */ | |||
| public int ttl() { | |||
| // TODO: add a limit to TTL, like 255 and make this and below super more efficient | |||
There was a problem hiding this comment.
raised #28
| } | ||
|
|
||
| static final class Extra extends MapPropagationFields<SecondarySamplingState, Boolean> { | ||
| Extra() { | ||
| } | ||
|
|
||
| // avoids copy-on-write for each keys on initial construction | ||
| Extra(Map<SecondarySamplingState, Boolean> initial) { |
There was a problem hiding this comment.
TODO: we need benchmarks as this whole codebase can add a lot of overhead if we aren't careful.
|
feedback welcome post merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
SecondaryProvisionerwhich can add one or more sampling keys, and optionally sample locally if the same node is participating.Fixes #10