Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution guidelines -- mostly referential content #51

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Contribution guidelines -- mostly referential content #51

merged 1 commit into from
Oct 27, 2022

Conversation

quaid
Copy link
Member

@quaid quaid commented Oct 25, 2022

No description provided.

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2022
schwesig
schwesig approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022
@sesheta
Copy link
Member

sesheta commented Oct 26, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: schwesig
Once this PR has been reviewed and has the lgtm label, please assign amfred for approval by writing /assign @amfred in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schwesig schwesig merged commit 38a654c into operate-first:main Oct 27, 2022
@schwesig schwesig added hacktoberfest-accepted PR that has been accepted for hacktoberfest! hacktoberfest Issues targeting the hacktoberfest participants. labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwesig schwesig schwesig approved these changes

Assignees

@quaid quaid

@schwesig schwesig

Labels
hacktoberfest Issues targeting the hacktoberfest participants. hacktoberfest-accepted PR that has been accepted for hacktoberfest! lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quaid @sesheta @schwesig