[#61465] users in lists miss popover additional fixes #18034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EinLama
force-pushed
the
bug/61465-users-in-lists-miss-popover-additional-fixes
branch
from
b1873e6 to
b18e4d9
Compare
Works for both users and work packages.
…over cards The first feels weird. You should know who you are. The latter is even a bug, since a hover card will close when you try to open a new one -> prohibit this from happening. While on it, I decided to rework the way that a hover card is configured within the principal renderer. It now gets its own configuration object instead of piggybacking on the avatar options. It always felt wrong to cram the hover card options in there, too.
EinLama
force-pushed
the
bug/61465-users-in-lists-miss-popover-additional-fixes
branch
from
b18e4d9 to
e9f5864
Compare
EinLama
deleted the
bug/61465-users-in-lists-miss-popover-additional-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/61465
Additional code changes for the CKEditor can be found in commonmark-ckeditor-build#98
What are you trying to accomplish?
Fix occurrences where a hover card was expected, but did not show up:
Additionally fix two issues:
While I was at it, I fixed the way that hover card options are handled within the principal renderer. Hover cards have their own options-object now to configure whether they show up or not. Previously, this was crammed into the AvatarOptions. Since hover cards also render on usernames, it felt wrong to leave it like this.
This also allowed me to adjust the default values so that the additional two fixes from above were possible.
The work package lists two other occurrences where hover cards are missing:
Both of these were NOT added since the mentioned forms use native select elements. We cannot add popovers there without a major rework of the form.
Screenshots
team.planner.mov
CKEditor.mov
board.mov
What approach did you choose and why?
Merge checklist