Skip to content

Commit

Permalink
stashing changes
Browse files Browse the repository at this point in the history
  • Loading branch information
alexjoeyyong committed Jan 22, 2025
1 parent e55b860 commit 44f3733
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 112 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
[![Coverage Status](https://coveralls.io/repos/optimizely/nuclear-js/badge.svg?branch=master)](https://coveralls.io/r/optimizely/nuclear-js?branch=master)
[![Join the chat at https://gitter.im/optimizely/nuclear-js](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/optimizely/nuclear-js?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)

[![Sauce Test Status](https://saucelabs.com/browser-matrix/nuclearjs.svg)](https://saucelabs.com/u/nuclearjs)

Traditional Flux architecture built with ImmutableJS data structures.

## Documentation
Expand Down
7 changes: 1 addition & 6 deletions grunt/aliases.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,14 @@
module.exports = {
'test': [
'karma:chrome',

Check warning on line 3 in grunt/aliases.js

View workflow job for this annotation

GitHub Actions / build

Trailing spaces not allowed
'karma:firefox'

Check warning on line 4 in grunt/aliases.js

View workflow job for this annotation

GitHub Actions / build

Missing trailing comma
],

'sauce': [
'karma:sauce_modern',
'karma:sauce_ie',
'karma:sauce_mobile',
],

'ci': [
'eslint',
'clean:coverage',
'karma:coverage',
// 'coveralls', //doesn't seem to be a thing anymore.
//'sauce', TODO: investigate why sauce connect isnt working
],
}
35 changes: 17 additions & 18 deletions grunt/karma.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
var sauce = require('./sauce')
var path = require('path')
var path = require('path');

Check warning on line 1 in grunt/karma.js

View workflow job for this annotation

GitHub Actions / build

Extra semicolon

module.exports = {
options: {
// base path that will be used to resolve all patterns (eg. files, exclude)
basePath: path.join(__dirname, '../'),
// frameworks to use
// available frameworks: https://npmjs.org/browse/keyword/karma-adapter
frameworks: ['jasmine'],

// list of files / patterns to load in the browser
Expand Down Expand Up @@ -46,7 +44,7 @@ module.exports = {
chrome: {
frameworks: ['jasmine'],
reporters: ['progress', 'html'],
browsers: ['ChromeHeadless'], // Use ChromeHeadless instead of Chrome or PhantomJS
browsers: ['ChromeHeadless'], // Use ChromeHeadless for CI
customLaunchers: {
HeadlessChrome: {
base: 'ChromeHeadless',
Expand All @@ -57,10 +55,23 @@ module.exports = {
singleRun: true,
},

firefox: {
frameworks: ['jasmine'],
reporters: ['progress', 'html'],
browsers: ['FirefoxHeadless'], // Use FirefoxHeadless for CI
customLaunchers: {
HeadlessFirefox: {
base: 'FirefoxHeadless',
},
},
autoWatch: false,
singleRun: true,
},

coverage: {
frameworks: ['jasmine'],
reporters: ['progress', 'coverage'],
browsers: ['ChromeHeadless'],
browsers: ['ChromeHeadless', 'FirefoxHeadless'], // Run tests on both browsers for coverage
coverageReporter: {
reporters: [
{ type: 'html', dir: 'coverage/' },
Expand All @@ -84,16 +95,4 @@ module.exports = {
},
},
},

sauce_modern: {
options: sauce.modern,
},

sauce_ie: {
options: sauce.ie,
},

sauce_mobile: {
options: sauce.mobile,
},
}
};

Check warning on line 98 in grunt/karma.js

View workflow job for this annotation

GitHub Actions / build

Extra semicolon
85 changes: 0 additions & 85 deletions grunt/sauce.js

This file was deleted.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@
"karma-chrome-launcher": "^0.2.3",
"karma-coverage": "^0.4.2",
"karma-es5-shim": "https://github.com/pokehanai/karma-es5-shim/archive/v2.1.0.tar.gz",
"karma-firefox-launcher": "^2.1.3",
"karma-jasmine": "^0.3.6",
"karma-jasmine-html-reporter": "^0.1.8",
"karma-sauce-launcher": "^0.2.14",
"karma-webpack": "^1.7.0",
"load-grunt-config": "^0.17.1",
"lodash": "^4.17.11",
Expand Down

0 comments on commit 44f3733

Please sign in to comment.