[GR-45043] Translate more nodes in YARPTranslator #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The core library does not load yet with Prism but this helps finding out what node needs to be handled next.
…rom visitCallNode()
* Also rename these helpers for clarity.
* A single array argument is expected at runtime if there is any splat.
* Otherwise `:a == :b` would be true because it's thought to be isAttrAssign as "==" ends with "=". * Still not fully correct, needs ruby/prism#1715
…ot-yet-handled nodes
* So foo is added to the local variables map and found by the read node.
* With: OVERWRITE_PARSING_RESULTS=true TRUFFLE_PARSING_USE_ORIGINAL_TRANSLATOR=true jt mspec spec/truffle/parsing/parsing_spec.rb OVERWRITE_PARSING_RESULTS=true jt test spec/truffle/parsing/parsing_spec.rb
…scriptor * So we test more accurately in parsing specs.
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.