Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use biome to format code #567

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

ematipico
Copy link
Contributor

Hi peeps, how are you? 👋

I am proposing an alternative to Prettier, Biome. https://biomejs.dev/formatter/

My idea is to slowly adopt the tool, and slowly adopt also linter (alongside eslint for the time being) and import sorting.

The PR only applies changes to plugin-vitepress as a starting point. I am happy to guide the migration to the rest of the code base.

While I was replacing it, I realized that prettier isn't used in the code base, so I changed the biome options to meet ts-standard - the library that Michele uses. However, there are still some differences due to some inconsistencies in the code.

Let me know what you guys think. If the change is welcomed, we could use this PR to decide the formatting style of the code base.

Thank you :)

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 10:06am

@micheleriva
Copy link
Member

That's fantastic, thank you @ematipico !

@micheleriva micheleriva merged commit 9d89b9e into oramasearch:main Dec 7, 2023
2 checks passed
@ematipico ematipico deleted the chore/use-biome branch December 7, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants