Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Astro crash when using an image service #617 #618

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

okikio
Copy link
Contributor

@okikio okikio commented Jan 26, 2024

Fix issue #617

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-docs ❌ Failed (Inspect) Jan 26, 2024 8:41pm

@micheleriva
Copy link
Member

Hi @okikio, thank you so much for your PR! I fear there's just a small problem with the AstroBuildDoneArgs type, as it won't compile:

Error: @orama/plugin-astro:build: src/index.ts(120,60): error TS2339: Property 'dir' does not exist on type 'AstroBuildDoneArgs'.

could you please fix this? Apart from that, looks good to me

@okikio
Copy link
Contributor Author

okikio commented Jan 26, 2024

@micheleriva Fixed PTAL

Copy link
Member

@micheleriva micheleriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micheleriva micheleriva merged commit adb12bc into oramasearch:main Jan 26, 2024
3 checks passed
@okikio okikio deleted the patch-1 branch January 26, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants