refactor: simplify track reader manager and messenger use #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerryHowe
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
qweeah
as code owners
TerryHowe
force-pushed
the
progress-manager
branch
4 times, most recently
from
0aedce4
to
83dc8ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
+ Coverage 85.97% 86.03% +0.05%
==========================================
Files 118 119 +1
Lines 4228 4274 +46
==========================================
+ Hits 3635 3677 +42
- Misses 354 356 +2
- Partials 239 241 +2 ☔ View full report in Codecov by Sentry. |
TerryHowe
force-pushed
the
progress-manager
branch
9 times, most recently
from
b7b0a9a
to
d2ffbe7
Compare
TerryHowe
force-pushed
the
progress-manager
branch
from
d2ffbe7
to
6546b12
Compare
This was referenced Sep 28, 2024
TerryHowe
force-pushed
the
progress-manager
branch
3 times, most recently
from
c1f4e72
to
04ede71
Compare
Signed-off-by: Terry Howe <[email protected]>
TerryHowe
force-pushed
the
progress-manager
branch
from
04ede71
to
f2066cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If we just pass the messenger to reader, it will be a lot easier to test these packages.
Partial: #1461
Partial: #1449