Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker compose DRY refactor #1411

Merged
merged 1 commit into from
Nov 3, 2019
Merged

docker compose DRY refactor #1411

merged 1 commit into from
Nov 3, 2019

Conversation

amir-arad
Copy link

@amir-arad amir-arad commented Oct 30, 2019 •
edited
Loading

It can be further generalised at the cost of convolution
fixes #1318

itamararjuan
itamararjuan approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@itamararjuan itamararjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good :)

@amir-arad amir-arad mentioned this pull request Nov 3, 2019
Open
@amir-arad amir-arad merged commit db87ef0 into master Nov 3, 2019
@amir-arad amir-arad deleted the refactor/1318-DRY-in-docker-compose branch November 10, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netoneko netoneko netoneko left review comments

@itamararjuan itamararjuan itamararjuan approved these changes

@electricmonk electricmonk Awaiting requested review from electricmonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DRY in docker/test/docker-compose.yml
3 participants
@amir-arad @netoneko @itamararjuan