Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tui): improve the white theme support #23

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Sep 13, 2024

Description of change

Now we check the background color of the terminal and use a more fitting color for text. (e.g. white text on a black background)

Closes #8

How has this been tested? (if applicable)

Locally, with different themes.

@orhun
Copy link
Owner Author

orhun commented Sep 13, 2024

100ms timeout seems a bit high - I need to make it run in a thread via message passing.

@orhun
Copy link
Owner Author

orhun commented Sep 14, 2024

Found another library which might be more suitable for this: https://github.com/Canop/terminal-light

@orhun
Copy link
Owner Author

orhun commented Sep 17, 2024

100ms timeout seems a bit high - I need to make it run in a thread via message passing.

Turns out this is not going to work since we can't query the terminal background color correctly while the terminal events are being read at the same time.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Project coverage is 3.55%. Comparing base (29d88dc) to head (52f7ced).

Files with missing lines Patch % Lines
src/tui/ui.rs 0.00% 99 Missing ⚠️
src/tui/state.rs 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #23      +/-   ##
========================================
- Coverage   3.67%   3.55%   -0.11%     
========================================
  Files         18      18              
  Lines       2212    2286      +74     
========================================
  Hits          81      81              
- Misses      2131    2205      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun changed the title feat(tui): improve white theme support feat(tui): improve the white theme support Sep 17, 2024
@orhun orhun merged commit c5c0e35 into main Sep 17, 2024
14 checks passed
@orhun orhun deleted the feat/improve_white_theme_support branch September 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White Bold texts are hidden in Light Theme.
2 participants