Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic): make dynamic analysis optional for better platform support #31

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Sep 15, 2024

Description of change

This PR makes it possible to build binsider without dynamic analysis feature thus without lurk-cli dependency.

Simply run:

cargo build --no-default-features

Potential workaround for #10, #12, #15 and other similar issues.

How has this been tested? (if applicable)

Locally.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 145 lines in your changes missing coverage. Please review.

Project coverage is 3.50%. Comparing base (3179751) to head (bb5d35e).

Files with missing lines Patch % Lines
src/tui/ui.rs 0.00% 145 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #31      +/-   ##
========================================
- Coverage   3.53%   3.50%   -0.02%     
========================================
  Files         18      18              
  Lines       2301    2317      +16     
========================================
  Hits          81      81              
- Misses      2220    2236      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner Author

orhun commented Sep 15, 2024

We should also publish pre-built binaries for the newly added platforms :)

@orhun orhun merged commit 580c9ec into main Sep 18, 2024
27 checks passed
@orhun orhun deleted the feat/optional_dynamic_analysis branch September 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants