fix(install): fix running on windows host #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed.
.exeextension for Windows host has been added for binary files.install.sh
set -euo pipefailAdded
-eflag to exit the script if return code of one of the commands is different from0.For example if
curlcommand with--failoption will fail, script will continue to execute without this flag.A choice of extension and unpacker (
.zipand7zfor Windows) was added to the host system detection part.run.sh
Fixed stylistic errors,
install.shused 4 tabs for indentation, whilerun.shused only 2.Note
Please merge the last two commits because they fix the same problem.