Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also update identifiers #4321

Merged
merged 4 commits into from
Feb 26, 2025
Merged

fix: also update identifiers #4321

merged 4 commits into from
Feb 26, 2025

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Feb 26, 2025

This fixes a bug where when an identity is merged into another, the identifier of the original identity was not updated.

@hperl hperl self-assigned this Feb 26, 2025
@hperl hperl requested review from aeneasr and a team as code owners February 26, 2025 07:50
@hperl hperl force-pushed the hperl/use_auto_link-fix branch from b4cb34e to 0afbfab Compare February 26, 2025 07:58
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (a4fd8ac) to head (b2907d5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/strategy/oidc/strategy_login.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4321      +/-   ##
==========================================
- Coverage   78.55%   78.53%   -0.02%     
==========================================
  Files         381      381              
  Lines       27482    27392      -90     
==========================================
- Hits        21589    21513      -76     
+ Misses       4256     4250       -6     
+ Partials     1637     1629       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl requested a review from aeneasr February 26, 2025 10:26
@hperl hperl enabled auto-merge (squash) February 26, 2025 10:42
@hperl hperl merged commit 7c63727 into master Feb 26, 2025
26 checks passed
@hperl hperl deleted the hperl/use_auto_link-fix branch February 26, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants