fix: IdentityCreated is over-reporting on error inserts #4323
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defer` was the incorrect code path here, as we should only record identity created if the transaction did not error (aka was rolled back).
aeneasr
commented
Feb 26, 2025
| @@ -553,14 +553,6 @@ func (p *IdentityPersister) CreateIdentities(ctx context.Context, identities ... | |||
| } | |||
|
|
|||
| var succeededIDs []uuid.UUID | |||
|
|
|||
| defer func() { | |||
There was a problem hiding this comment.
This runs always, even if the transaction block fails.
aeneasr
commented
Feb 26, 2025
| @@ -651,6 +643,12 @@ func (p *IdentityPersister) CreateIdentities(ctx context.Context, identities ... | |||
| }); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| // Report succeeded identities as created. | |||
| for _, identID := range succeededIDs { | |||
There was a problem hiding this comment.
I'm not entirely sure if this is entirely correct or if we can end up with an error in the transaction block but still have the identity partially available.
There was a problem hiding this comment.
No, I think this is really the right place.
hperl
approved these changes
Feb 26, 2025
| @@ -651,6 +643,12 @@ func (p *IdentityPersister) CreateIdentities(ctx context.Context, identities ... | |||
| }); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| // Report succeeded identities as created. | |||
| for _, identID := range succeededIDs { | |||
There was a problem hiding this comment.
No, I think this is really the right place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deferwas the incorrect code path here, as we should only record identity created if the transaction did not error (aka was rolled back).Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments