Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove foo={proj} workaround from sources #2629

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Remove foo={proj} workaround from sources #2629

merged 2 commits into from
Feb 13, 2025

Conversation

arch0345
Copy link
Contributor

Closes #2628

Also use {wkid} parameter instead of hardcoding bboxSR and imageSR values

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (matches what I had stupidly done in #2631 independently).

I'm not sure if scripts/sources/oceania/au/nsw/NSW_SS_Floods.js is still relevant/used at all or not, but there are would also be one remaining place with hardcoded 3857 and foo={proj}:

-            result.properties.url = `https://portal.spatial.nsw.gov.au/server/rest/services/${service}/MapServer/export?f=image&format=png&transparent=true&imageSR=3857&bboxSR=3857&bbox={bbox}&size={width},{height}&layers=show:${id}&foo={proj}`;
+            result.properties.url = `https://portal.spatial.nsw.gov.au/server/rest/services/${service}/MapServer/export?f=image&format=png&transparent=true&imageSR={wkid}&bboxSR={wkid}&bbox={bbox}&size={width},{height}&layers=show:${id}`;

@arch0345
Copy link
Contributor Author

Looks good to me (matches what I had stupidly done in #2631 independently).

I'm not sure if scripts/sources/oceania/au/nsw/NSW_SS_Floods.js is still relevant/used at all or not, but there are would also be one remaining place with hardcoded 3857 and foo={proj}:

-            result.properties.url = `https://portal.spatial.nsw.gov.au/server/rest/services/${service}/MapServer/export?f=image&format=png&transparent=true&imageSR=3857&bboxSR=3857&bbox={bbox}&size={width},{height}&layers=show:${id}&foo={proj}`;
+            result.properties.url = `https://portal.spatial.nsw.gov.au/server/rest/services/${service}/MapServer/export?f=image&format=png&transparent=true&imageSR={wkid}&bboxSR={wkid}&bbox={bbox}&size={width},{height}&layers=show:${id}`;

Good catch, I was just searching through the .geojson files. I noticed that the PR check script is still flagging the missing {proj} parameters, would it be possible for {wkid} to be added as a synonym for this too?

@tyrasd
Copy link
Member

tyrasd commented Feb 13, 2025

I've pushed 3398fc0 to this branch which adds {wkid} also to the strict_check.py script.

@arch0345 arch0345 merged commit 95b9428 into gh-pages Feb 13, 2025
0 of 2 checks passed
@arch0345 arch0345 deleted the wkid branch February 13, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove foo={proj} workaround from sources
2 participants