Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress when creating a CSCmatrix #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yixing312
Copy link

In the original code, the matrix was not properly compressed. In particular, using the 'from_column_iter_dense' and 'from_row_iter_dense' functions to create a new matrix containing 0, the created matrix does not match the result created by 'slice.into()'.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

@ebarnard
Copy link
Collaborator

The function calling this code is called from_row/column_iter_dense and documents that it Creates a dense CSC matrix. This might be better in a function called something like compress_zeros, or separate methods without the dense suffix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants