UI ux update #152
Merged
UI ux update #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplescreenrecorder-2022-11-07_14.58.20.mp4 |
Asam237
requested changes
Nov 7, 2022
frontend/src/pages/404.tsx
Outdated
|
|
||
| export const NotFound = () => { | ||
| const {t} = useTranslation(); | ||
| console.log("ici") |
| sizeLarge: { | ||
| height: 42, | ||
| }, | ||
| // contained |
|
Looks great I left you some comments and it is necessary to fix the bug concerning the route on the details of an alert on a region and change the port in config of the frontend 5000 instead of 8000 simplescreenrecorder-2022-11-07_18.43.32.mp4 |
6 tasks
Closed
…to ui_ux_update � Conflicts: � frontend/src/config.ts � frontend/src/pages/404.tsx � frontend/src/pages/advices/Advices.tsx � frontend/src/pages/detail/Detail.page.tsx � frontend/src/translations/fr.ts
Asam237
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
How ?
Why