Allow moving the metadata part of JSC::BuiltinExecutables::createExecutable to a generator script
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cutable` to compile-time
paperdave
reviewed
Oct 31, 2023
| return createExecutable(vm, source, name, implementationVisibility, constructorKind, constructAbility, needsClassFieldInitializer, privateBrandRequirement, meta); | ||
| } | ||
|
|
||
| BuiltinExecutableMetadata::BuiltinExecutableMetadata(const unsigned char* characters, unsigned length) |
There was a problem hiding this comment.
this should be moved in BuiltinExecutableMetadata.cpp, but it would make rebasing harder, but also alot of stuff in this function is already going to merge conflict.
There was a problem hiding this comment.
yeah it needs to be kept in sync with whatever variables change below it
There was a problem hiding this comment.
If this is going to make merging harder and there is an open issue by an apple employee is this a candidate to push to webkit (see if they are open to it)?
paperdave
reviewed
Oct 31, 2023
| class BuiltinExecutableMetadata { | ||
| public: | ||
| BuiltinExecutableMetadata(const unsigned char* data, unsigned length); | ||
| BuiltinExecutableMetadata() = default; |
There was a problem hiding this comment.
this constructor BuiltinExecutableMetadata() should not exist
There was a problem hiding this comment.
it most definitely should exist because that is how we run it in a generator script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.webkit.org/show_bug.cgi?id=193272