Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13071 ensure unix path when running in windows #13099

Conversation

mkdirJava
Copy link

What does this PR do?

Fix for
#13071

method:
randomUnixPath()
found in
packages\bun-debug-adapter-protocol\src\debugger\signal.ts

makes use of
import { tmpdir } from "node:os";
which returns a temp path, since the method is called "randomUnixPath" it can create a Windows path, which causes issues in debugging

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@Electroid
Copy link
Contributor

Thank for you opening a pull request, but this will not fix the issue. It is more complicated than that.

@Electroid Electroid closed this Aug 5, 2024
@mkdirJava
Copy link
Author

Hey @Electroid,
I figured it would be complicated. I noticed the source comes from a lib that mentioned it produces path with respect to OS platform.

Therefore it makes me think. Is the debugging feature of Bun being built in a two steps? Witht he first fixed to an Unix system?

Happy to be wrong but wanted to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants