New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing exception check to Bun.connect & Bun.listen #13883

Open

Jarred-Sumner wants to merge 3 commits into main from jarred/exception-check

Collaborator

Jarred-Sumner commented Sep 11, 2024

What does this PR do?

Add missing exception check to Bun.connect & Bun.listen

How did you verify your code works?


          Add missing exception check to Bun.connect & Bun.listen

be06bd6

robobun commented Sep 11, 2024 •

edited

Loading

❌ @Jarred-Sumner, your commit 9ff8282 has 9 failures in #3357:

test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🐧 20.04 aarch64

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64

test/js/web/streams/streams.test.js - 1 failing on 🍎 13 aarch64

test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64

test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline

test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64-baseline

test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64

test/js/web/timers/setInterval.test.js - 1 failing on 🍎 14 aarch64

test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 14 aarch64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 13 aarch64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 aarch64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 22.04 x64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 22.04 x64-baseline

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 12 x64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 20.04 x64-baseline

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 20.04 x64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 12 x64-baseline

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 13 x64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 x64

Jarred-Sumner added 2 commits

September 11, 2024 20:06


          Merge branch 'main' into jarred/exception-check

5a964e2


          Merge branch 'main' into jarred/exception-check

9ff8282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet