Fixes #13816 #13906
Merged
Fixes #13816 #13906
+148
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @pfgithub, your commit 163f922 has 1 failures in test/cli/hot/hot.test.ts - timeout on 🪟 2019 x64-baseline |
pfgithub
force-pushed
the
jarred/resume-webkit-streams-fixes
branch
2 times, most recently
from
060113d
to
d8ede81
Compare
Ignore ERR_STREAM_RELEASE_LOCK in process.stdin Reject pending reads when a ReadableStream's lock is released WebKit/WebKit@f8ae40c Update the ReadableStream promise resolution ordering on pull rejection WebKit/WebKit@1f74c15 Fix pipeThrough unhandled rejections on readable errors WebKit/WebKit@07e4b92 Fix pipeTo unhandled rejections on readable errors WebKit/WebKit@3a75b5d Fixes #13816.
…update the test to wait for stdout rather than waiting 100ms before the first write
pfgithub
force-pushed
the
jarred/resume-webkit-streams-fixes
branch
from
d8ede81
to
40e0b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I wanted to go and make some changes to #13840, so here's a slightly revised version with test failures hopefully fixed
Closes #13840
Fixes #13816
How did you verify your code works?
Tests