Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feature: Bun "zsh" completions for commands with colons #13927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ragokan
Copy link

@ragokan ragokan commented Sep 12, 2024

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes
  • Changes for ZSH completions

Problem

Solution

  • Replace "bun getcompletes i" and "bun getcompletes s" with "bun getcompletes z" which also gives the value of script.
  • Add some regexes to not split from ":", instead use spaces.

Extra

  • Thanks to "bun getcompletes z", we also get what a script do, so I also added them. Results;
ScreenShot 2024-09-13 at 00 09 12 ScreenShot 2024-09-13 at 00 09 28

What is missing?

  • It truncates the value, I don't know why yet.

@ragokan ragokan changed the title Fix/Feature: Bun "zsh" completions for commands with colons fix/feature: Bun "zsh" completions for commands with colons Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant