Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zig path in GH action #14007

Closed
wants to merge 12 commits into from
Closed

Conversation

robertshuford
Copy link
Contributor

@robertshuford robertshuford commented Sep 18, 2024

What does this PR do?

This fixes the zig path problem in the GitHub Actions .github/workflows/run-format.yml and .github/workflows/format.yml.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)

How did you verify your code works?

I ran the action on my fork for this branch: https://github.com/robertshuford/bun/actions/runs/10914651113.

@robertshuford
Copy link
Contributor Author

Is this worth fixing?
Or does the removal of "zig": "vendor/zig/zig.exe" cause downstream issues I'm unaware of?

@robertshuford
Copy link
Contributor Author

Fixed in #14152

@robertshuford robertshuford deleted the fix-zig-fmt branch September 26, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant