Fix express responses dying early #18080
Merged
+22
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes ServerResponse.finished not being initialized to false on construction. This (sometimes) caused Express responses to never complete. (Fixed version of #18078)
How did you verify your code works?
In addition to running the node:http tests, I ran this reproduction provided on Discord by @Lillious and spammed refresh with cache disabled on a simple index.html page that includes an image:
Before this fix, it would sometimes fail to load the image or the page itself. Now it always succeeds.