Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node:vm test #18081

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix node:vm test #18081

wants to merge 3 commits into from

Conversation

zackradisic
Copy link
Member

Fixed this test: test-vm-new-script-context.js

  • Changed WebKit's reference error string from "Can't find variable: foo" -> "foo is not defined" to match V8 and fix (see here)
  • Change error message for Script.runInContext to match node

@robobun
Copy link

robobun commented Mar 11, 2025

Updated 5:10 PM PT - Mar 11th, 2025

@zackradisic, your commit 885c396 has 4 failures in Build #13032:


🧪   try this PR locally:

bunx bun-pr 18081

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants