remove a memory leak in bun.String.concat/createFromConcat #18084
+17
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 5:47 PM PT - Mar 11th, 2025
✅ @paperclover, your commit 2e95c2dae8799e7f858d04a25814e429d12c88bb passed in 🧪 try this PR locally: bunx bun-pr 18084 |
DonIsaac
reviewed
Mar 12, 2025
| const prefix = "http://"; | ||
| const url_str = switch (input.is8Bit()) { | ||
| inline else => |is_8_bit| with_prefix: { | ||
| const enc: bun.String.WTFEncoding = if (is_8_bit) .latin1 else .utf16; |
There was a problem hiding this comment.
could/should this be a bun.String method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the function
bun.String.createFromConcatandbun.String.concathave a memory leak, and make too many allocations. since there is exactly one usage of this function, the easiest solution is to just delete it.