Better edge case handling in napi_value<->String conversion #18107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 9:36 PM PT - Mar 11th, 2025
❌ @190n, your commit b763910 has some failures in 🧪 try this PR locally: bunx bun-pr 18107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes several bugs in
napi_get_value_string_*andnapi_create_string_*exposed by exhaustive testing.napi_get_value_string_*still doesn't handle unpaired surrogates correctly, but this is still strictly better than status quo.Fixes #18069
Fixes #18079
How did you verify your code works?
Added new tests and ran the existing tests (ours and Node's)