Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bun --inspect with fully-qualified URL #8267

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix bun --inspect with fully-qualified URL #8267

merged 1 commit into from
Jan 19, 2024

Conversation

Electroid
Copy link
Contributor

What does this PR do?

Fixes #8250

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Added tests

Copy link
Contributor

Copy link
Contributor

❌🪟 @Electroid, there are 4 test regressions on Windows x86_64

  • test\cli\inspect\inspect.test.ts
  • test\js\node\events\events-cjs.test.js
  • test\js\web\websocket\autobahn.test.ts
  • test\regression\issue\08095.test.ts

Full Test Output

@Jarred-Sumner Jarred-Sumner merged commit e17709a into main Jan 19, 2024
26 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the fix-8250 branch January 19, 2024 02:32
@Jarred-Sumner
Copy link
Collaborator

Thank you

ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to debug with Bun VSCode Extension
2 participants