Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dedicated): correct revert snapshot instead of restore #13510

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(dedicated): correct revert snapshot instead of restore #13510

merged 2 commits into from
Nov 14, 2024

Conversation

mhelhali-soufien
Copy link
Contributor

@mhelhali-soufien mhelhali-soufien commented Oct 9, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #MANAGER-15297
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Translation

  • CMT-18018

fix(dedicated): correct revert snapshot instead of restore
f1aad20 
  ref: MANAGER-15297

Signed-off-by: soufien mhelhali <[email protected]>
@mhelhali-soufien mhelhali-soufien requested a review from a team as a code owner October 9, 2024 06:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sachinrameshn
sachinrameshn previously approved these changes Oct 10, 2024
View reviewed changes
qpavy
qpavy previously approved these changes Oct 10, 2024
View reviewed changes
@antleblanc antleblanc dismissed stale reviews from qpavy and sachinrameshn via acc7cf8 November 14, 2024 16:35
@sachinrameshn sachinrameshn changed the base branch from master to release/infra-hpc-w47 November 14, 2024 16:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sachinrameshn sachinrameshn merged commit 991edba into release/infra-hpc-w47 Nov 14, 2024
14 of 17 checks passed
@sachinrameshn sachinrameshn deleted the fix/MANAGER-15297 branch November 14, 2024 16:58
@sachinrameshn sachinrameshn mentioned this pull request Nov 14, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@darsene darsene darsene approved these changes

@qpavy qpavy qpavy left review comments

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working quality check: ok translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhelhali-soufien @qpavy @darsene @sachinrameshn